Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify detection of credentials to use for cypress tests #4580

Merged
merged 2 commits into from
Feb 7, 2025
Merged

chore: modify detection of credentials to use for cypress tests #4580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d0103e
chore: modify detection of credentials to use for cypress tests
techfg Feb 7, 2025
9da4b3b
chore: add comment
techfg Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ jobs:

- name: Build and test
env:
UESIO_DEV: "true"
UESIO_DEV: "true" # required to ensure packui gets built
run: npx nx affected -t build test --configuration=ci --parallel=5

- name: Prep for docker image
id: setDockerSHAs
env:
UESIO_DEV: "true"
UESIO_DEV: "true" # required to ensure packui gets built
run: |
# We lint/test/build affected but in order to build image, we need to ensure everything
# is built. Build anything that hasn't been built yet (takes advantage of nx cache
Expand Down Expand Up @@ -207,13 +207,9 @@ jobs:
run: npm ci

- name: Check formatting
env:
UESIO_DEV: "true"
run: npx nx format:check --verbose

- name: Lint
env:
UESIO_DEV: "true"
run: npx nx affected -t lint --configuration=ci --parallel=5

typecheck:
Expand Down Expand Up @@ -245,8 +241,6 @@ jobs:
run: npm ci

- name: Typecheck
env:
UESIO_DEV: "true"
run: npx nx affected -t typecheck --configuration=ci --parallel=5

update-dev-branch:
Expand Down
7 changes: 1 addition & 6 deletions apps/platform-e2e/cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,8 @@ const studioBaseUrl =
process.env.UESIO_APP_URL || `https://studio.uesio-dev.com:3000`
const automationUsername = process.env.UESIO_AUTOMATION_USERNAME || "uesio"
const automationPassword = process.env.UESIO_AUTOMATION_PASSWORD
const useMockLogin = process.env.UESIO_DEV
const useMockLogin = !automationPassword
const inCi = process.env.CI === "true"

if (!useMockLogin && !automationPassword) {
throw new Error("UESIO_AUTOMATION_PASSWORD was not provided")
}

export default defineConfig({
e2e: {
...nxE2EPreset(__filename, {
Expand Down
Loading