Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor test scripts #4577

Merged
merged 10 commits into from
Feb 7, 2025
Merged

chore: refactor test scripts #4577

merged 10 commits into from
Feb 7, 2025

Conversation

techfg
Copy link
Collaborator

@techfg techfg commented Feb 6, 2025

What does this PR do?

Refactors and improve tests scripts and test execution:

  1. Modularizes test scripts for re-usability
  2. Ensures test suites complete successfully when run in isolation (e.g., e2e no longer requires integration to have run)
  3. Moves ssl setup out of docker test runs to avoid potential interactive prompts due to sudo
  4. Ensures all test related apps/workspaces/sites/data is fully removed after each test run
  5. Ensures latest code is built prior to creating docker image for tests
  6. Updates docs to align with current test process/scripts/etc.
  7. Uses environment variables throughout all tests to avoid hardcoded values in multiple places
  8. updates npm scripts in package.json
  9. Changes nomenclature of tests-ci to tests-docker since ci workflows actually run unit/integration/e2e while tests-ci script only ran integration/e2e.
  10. Standardizes naming convention/format of all test related scripts to *-tests.sh (e.g., previously was mixture of *-tests & tests-*).

Resolves #4574

Testing

All tests pass locally, ci workflow will test everything to make sure.

@techfg techfg requested a review from humandad February 6, 2025 12:38
@techfg techfg self-assigned this Feb 6, 2025
@humandad humandad merged commit ed612d8 into main Feb 7, 2025
5 checks passed
@humandad humandad deleted the chore/update-test-scripts branch February 7, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: testing issues (e.g., docs, failures, etc.)
2 participants