Treat if merge with false string as false #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have an
$If{}merge that accepts a three-part value. First a condition, and then an if_true_merge and finally, and if_false_merge.Since we merge into template strings in multiple stages, merges in the condition could result in the string "false". These conditions should still trigger the "false" condition, not the "true" condition.
Example Merge:
$If{[$Prop{collapsed}][trueValue][falseValue]}If
$Prop{collapsed}resolves to the string "false" we want the falseValue to be the final result of the if merge.