Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrieve types only command #4555

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

humandad
Copy link
Contributor

@humandad humandad commented Feb 4, 2025

What does this PR do?

Adds an option to uesio retrieve to only retrieve app specific type definitions.

uesio retrieve --onlyTypes

@humandad humandad requested a review from techfg February 4, 2025 01:36
@humandad humandad self-assigned this Feb 4, 2025
Copy link
Collaborator

@techfg techfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one main question

@@ -26,6 +26,7 @@ func init() {
Long: "Retrieves all metadata from a remote workspace to the local directory",
Run: workspaceRetrieve,
}
workspaceRetrieveCmd.Flags().BoolP("onlyTypes", "t", false, "Only retrieve types")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop the shorthand t for now or at least until we know this is going to stick. Thinking t might be common for other types of things down the road and onlyTypes is more than likely a less commonly used flag. Thoughts?

@@ -72,13 +73,17 @@ func init() {
Short: "uesio retrieve",
Run: workspaceRetrieve,
}
oldRetrieveCommand.Flags().BoolP("onlyTypes", "t", false, "Only retrieve types")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above regarding t

@humandad humandad merged commit a5e10ba into main Feb 4, 2025
5 checks passed
@humandad humandad deleted the add-retrieve-types-only-command branch February 4, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants