Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testing issues (e.g., docs, failures, etc.) #4574

Closed
techfg opened this issue Feb 6, 2025 · 0 comments · Fixed by #4577
Closed

chore: testing issues (e.g., docs, failures, etc.) #4574

techfg opened this issue Feb 6, 2025 · 0 comments · Fixed by #4577

Comments

@techfg
Copy link
Collaborator

techfg commented Feb 6, 2025

There are a number of issues with the current tests:

  1. e2e tests are written with assertions that fail when run in isolation (e.g., they only pass 100% if integration tests have run first)
  2. Docs do not clearly and completely specify how tests can/should be run - for example:
    1. npm run tests-init must be run before npm run tests-e2e or when executing individual tests via hurl, etc.
    2. npm run build-all should be run before any tests to ensure the latest code is being tested
    3. npm run start must be run for any test scripts (except `npm run tests-ci``
    4. SSL must be configured first (npm run setup-ssl)
  3. hostname/port/url/etc. are hardcoded in several different places making it difficult to maintain and also to run tests against different endpoints

The following should be improved/changed:

  1. Docs updated to accurately and completely reflect how to run any of the test scripts
  2. Tests should completely successfully when run in isolation
  3. Tests should use environment variables to obtain "config" values
@techfg techfg changed the title chore: testing issues (e.g., docs, failures, etc. chore: testing issues (e.g., docs, failures, etc.) Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant