Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mobile footer #12

Closed
wants to merge 1 commit into from
Closed

feat: add mobile footer #12

wants to merge 1 commit into from

Conversation

EdwardNew
Copy link
Member

✨ Tracking

Resolves Issue #1

🌱 Changes

  • Created MobileFooter component
  • Added MobileFooter component to bottom of section in Judges Page
  • Added font size variables for paragraph and footer in variables.scss

📝 Testing

  • Works as expected locally in chrome and firefox on desktop
  • Have not tested on mobile
  • Have not tested on Safari

Know Bugs

  • wrapping gets weird when screen width is below 180px

💻 Did you test on all browsers?

  • Yes
  • No

📷Screenshots

image

image

@EdwardNew EdwardNew linked an issue Apr 3, 2024 that may be closed by this pull request
Mobile Footer #1
Closed
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for designfrontiers24 ready!

Name Link
🔨 Latest commit 0d997a5
🔍 Latest deploy log https://app.netlify.com/sites/designfrontiers24/deploys/660cab328030800008d373c8
😎 Deploy Preview https://deploy-preview-12--designfrontiers24.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aaronchan32
aaronchan32 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@aaronchan32 aaronchan32 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good work :) I tested on mobile safari.

@aaronchan32 aaronchan32 closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronchan32 aaronchan32 aaronchan32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile Footer
2 participants
@EdwardNew @aaronchan32