Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in.region #16

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Update in.region #16

merged 4 commits into from
Mar 25, 2025

Conversation

mluo123
Copy link
Contributor

@mluo123 mluo123 commented Apr 18, 2024

Description

In.region was updated to include an extra parameter for specifying sorting method. Input files are now sorted according to the parameter rather than "lexicon" by default. Test cases are also changed to reflect "natural" sorting by default, along with an option to check lexicographical sorting.

Checklist

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

@mluo123 mluo123 self-assigned this Apr 18, 2024
@dan-knight
Copy link
Contributor

Thanks for this fix @mluo123! Apologies for the delay in reviewing. The code looks good to me, but I've also added @whelena to see if she has any thoughts before we approve/merge.

Copy link
Collaborator

@whelena whelena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dan-knight dan-knight merged commit a6de2ed into main Mar 25, 2025
5 checks passed
@dan-knight dan-knight deleted the in.region-update branch March 25, 2025 23:31
@dan-knight dan-knight linked an issue Mar 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In.region returning inaccurate results
3 participants