Update 'Requester' to include new_quizzes_url attribute (#684) #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

zeeawada wants to merge 1 commit into ucfopen:develop from zeeawada:issue/684-fix-missing-new-quizzes-url

zeeawada commented Apr 24, 2025

Proposed Changes

Add a new_quizzes_url attribute to "Requester"
Change _get_next_page in paginated_list.py to use an empty string if new_quizzes_url is not defined which resolved the crash.
Included a test in test_assignment.py called test_get_submissions_without_new_quizzes_url in order to make sure my changes worked.

All tests passed and coverage remained at 100%.

Fixes #684


          Update 'Requester' to include new_quizzes_url attribute (ucfopen#684)

3e6cfcf

zeeawada requested review from Thetwam, bennettscience and jonespm as code owners

April 24, 2025 23:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Thetwam Awaiting requested review from Thetwam Thetwam is a code owner

bennettscience Awaiting requested review from bennettscience bennettscience is a code owner

jonespm Awaiting requested review from jonespm jonespm is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet