-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display emojis with test results #533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also look at adding the emojis to the new exception-based test files? I think editing message
in the run()
method should be sufficient: https://github.com/ucbds-infra/otter-grader/blob/master/otter/test_files/exception_test.py#L156
@joelostblom can you also add an entry to the changelog? |
@chrispyles I had a go at doing this the same way as for the regular ok-tests, but there seem to be not test files in otter CI to check exception based tests so not sure I have gotten it right. I am not familiar with this new format of tests and I am not clear on the differences versus the old format after reading the docs, so I might need some help if there are significant other changes needed. |
Codecov ReportBase: 72.53% // Head: 72.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
==========================================
- Coverage 72.53% 72.17% -0.37%
==========================================
Files 64 62 -2
Lines 3921 3748 -173
==========================================
- Hits 2844 2705 -139
+ Misses 1077 1043 -34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
+1. I need to add tests for this behavior. |
test_that
in R does and is more of a fun touch.Individual tests:
All tests: