fix(accessibilityFixes): Accessibility Fixes #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarvisraymond-uchicago
changed the title
… to allow for skip to main button
…to bottom, removed unneeded import
…nt for Head in _document.tsx
mfshao
reviewed
Mar 10, 2025
| const PageTitle: React.FC<PageTitleProps> = ({ pageName }) => { | ||
| return ( | ||
| <Head> | ||
| <title>{`${pageName} | HEAL Data Platform`}</title> |
There was a problem hiding this comment.
should we compensate for if pageName is not provided?
There was a problem hiding this comment.
I think this is ok for now
- If another DEV creates a page using the PageTitle component, TypesScript will require that they pass the pageName prop with a string
- If a page is created without the PageTitle component, the user's web browser will display the URL of the page or the name of the website as the title in the title bar or tab. In some cases, it may also show "Untitled" or a similar default message, depending on the browser being used.
- If we need different functionality going forward, like pages with a default page title such as only "HEAL Data Platform" we can add that functionality when needed.
mfshao
approved these changes
Mar 10, 2025
cemile-ctds
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Please add a background color to the quote section, like hero section. In the event that the image is not displayed, we need a fallback color to ensure the quote text is still visible. Additionally, please ensure the color contrast ratio between the text and background meets accessibility standards for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/HP-1748
Accessibility Fixes
<title>element to both pages: the HTML titles will use format "Page Title | HEAL Data Platform"lang="en"attribute to<html>element<main>elementBEFORE
AFTER
Skip to main added:
Automated axe DevTools tests pass 100%
Improvements