Skip to content

fix: reinstate tests #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

fix: reinstate tests #135

wants to merge 5 commits into from

Conversation

@pieterlukasse
Copy link

@pieterlukasse pieterlukasse commented May 2, 2024 •
edited
Loading

Reinstate tests, rolling back what was done in OHDSI#1903

Upstream PR: OHDSI#2368

@pieterlukasse
Copy link
Author

pieterlukasse commented May 2, 2024 •
edited
Loading

first run: https://github.com/uc-cdis/WebAPI/actions/runs/8928129787/job/24522987771

[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    CohortCharacterizationServiceTest.testExportGeneration:105->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@73e73d8a[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>
Error:    CohortCharacterizationServiceTest.testExportGenerationWithStrata:110->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@64020bab[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>
Error:    PermissionTest.permsTest:85->AbstractDatabaseTest.loadPrepData:112 Exception processing table name='public.sec_role'
Error:    PermissionTest.wildcardTest:101->AbstractDatabaseTest.loadPrepData:112 Exception processing table name='public.sec_role'
[INFO] 
Error:  Tests run: 220, Failures: 4, Errors: 0, Skipped: 0

second run: https://github.com/uc-cdis/WebAPI/actions/runs/8928129787/job/24524131137

[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    CohortCharacterizationServiceTest.testExportGeneration:105->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@5f468112[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>
Error:    CohortCharacterizationServiceTest.testExportGenerationWithStrata:110->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@7ce6587b[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>
Error:    PermissionTest.permsTest:85->AbstractDatabaseTest.loadPrepData:112 Exception processing table name='public.sec_role'
Error:    PermissionTest.wildcardTest:101->AbstractDatabaseTest.loadPrepData:112 Exception processing table name='public.sec_role'
[INFO] 
Error:  Tests run: 220, Failures: 4, Errors: 0, Skipped: 0

third run: https://github.com/uc-cdis/WebAPI/actions/runs/8928129787/job/24525468942

[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    CohortCharacterizationServiceTest.testExportGeneration:105->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@130c39d9[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>
Error:    CohortCharacterizationServiceTest.testExportGenerationWithStrata:110->doTestExportGeneration:132->checkRequest:151 Checking dataitem org.ohdsi.webapi.cohortcharacterization.CohortCharacterizationServiceTest$ParamItem@747b18e5[analysisIds=[107],cohortIds=[2],isSummary=false,isComparative=false] expected:<1> but was:<0>
Error:    PermissionTest.permsTest:85->AbstractDatabaseTest.loadPrepData:112 Exception processing table name='public.sec_role'
Error:    PermissionTest.wildcardTest:101->AbstractDatabaseTest.loadPrepData:112 Exception processing table name='public.sec_role'
[INFO] 
Error:  Tests run: 220, Failures: 4, Errors: 0, Skipped: 0

thought: if the same 4 tests always fail, why not start skipping them for now instead of disabling all 220? 🤔

@pieterlukasse pieterlukasse force-pushed the fix/reinstate_tests branch from 8b49e90 to 707b173 Compare May 3, 2024 19:56
@pieterlukasse
tmp: skip broken CohortCharacterizationServiceTest tests
5ea83a4 
This allows the other tests to be reinstated while these two
can then be fixed separately.
@pieterlukasse
tmp: skip broken PermissionTest tests
ec6e298 
This allows the other tests to be reinstated while these two
can then be fixed separately.
@pieterlukasse
tmp: skip broken StudyInfoTest
ccc748b 
...this one seems to only work depending on the order of execution...
it lacks the setup() method where a pre-filled db is guaranteed, like
for example in CohortCharacterizationServiceTest
@pieterlukasse
fix: mark abstract class as abstract
7f084e2
@pieterlukasse
Copy link
Author

pieterlukasse commented Jun 20, 2024

replaced by OHDSI#2368 which was merged into our local branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pieterlukasse