Skip to content

Conversation

clemux
Copy link

@clemux clemux commented Oct 7, 2023

Listing windows seems to be working correctly. However :

  • capturing does not work for all windows. I get a black or white screen for some of them.
  • I don't know what xcffib.xproto.MapState.Viewable means. If it is equivalent to https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-iswindowvisible, I'll have to change _enum_windows_cb. For now it always returns (window_name, True)
  • I haven't tested on X11 to check that I didn't break anything
  • Tested only on Windows 11

I'l leave this PR a draft for now.

@clemux clemux changed the title Draft: Add win32 support for listing windows WIP: Add win32 support for listing windows Oct 7, 2023
@clemux clemux marked this pull request as draft October 7, 2023 12:38
@clemux clemux changed the title WIP: Add win32 support for listing windows Add win32 support for listing windows Oct 7, 2023
@clemux clemux force-pushed the list_windows_win32 branch from 3f015a2 to f1b8ff7 Compare October 7, 2023 12:44
Copy link
Owner

@ubitux ubitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

It seems you didn't break X11, works fine here, so feel free to remove the draft.

@ubitux
Copy link
Owner

ubitux commented Oct 7, 2023

Listing windows seems to be working correctly. However :

* capturing does not work for all windows. I get a black or white screen for some of them.

Does that happen for viewable windows?

* I don't know what `xcffib.xproto.MapState.Viewable` means. If it is equivalent to https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-iswindowvisible, I'll have to change `_enum_windows_cb`. For now it always returns `(window_name, True)`

It's supposed to be, I guess.

I will make it obvious in the combo box which window is visible or not (italic for non-visible, or maybe bold for visible)

Ah, also, can you update the README for the Windows mention?

@clemux clemux force-pushed the list_windows_win32 branch 3 times, most recently from 89ef84c to 13a132d Compare October 7, 2023 16:24
@clemux clemux force-pushed the list_windows_win32 branch from 13a132d to 83c86af Compare October 7, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants