Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing page parameter in event query #667

Merged
merged 1 commit into from
May 2, 2024
Merged

added missing page parameter in event query #667

merged 1 commit into from
May 2, 2024

Conversation

TheVVaS
Copy link
Contributor

@TheVVaS TheVVaS commented May 2, 2024

Somehow only per_page exists, added missing page

@TheVVaS TheVVaS requested a review from a team as a code owner May 2, 2024 11:41
@TheVVaS TheVVaS requested review from Toa741 and removed request for a team May 2, 2024 11:41
@louis-z
Copy link
Member

louis-z commented May 2, 2024

Thanks @TheVVaS for your contribution. You'll need to document the changes you made to the public API. The easiest way of doing that is to use the Visual Studio refactoring feature:

image

@TheVVaS
Copy link
Contributor Author

TheVVaS commented May 2, 2024

@louis-z I hope I did it right this time

@louis-z louis-z merged commit 9e7e8f3 into ubisoft:main May 2, 2024
4 checks passed
@TheVVaS TheVVaS deleted the fix/missing-page-parameter-in-event-query branch May 3, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants