Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async CRUD methods to IProjectClient #655

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Add async CRUD methods to IProjectClient #655

merged 5 commits into from
Apr 10, 2024

Conversation

belcher-rok
Copy link
Contributor

@belcher-rok belcher-rok commented Apr 4, 2024 •
edited
Loading

  • Adds async CRUD methods to IProjectClient.
  • Improves the Mock ProjectClient to better emulate actual GitLab behavior:
    • Project Create must specify Name or Path.
    • Auto-generate missing Path from Name, and vice-versa.
    • Cannot create project with duplicate Name (case-sensitive).
    • Cannot create project with duplicate Path (case-INsensitive).
    • Project.BuildTimeout is in seconds, not minutes.
    • GitLab ignores ProjectCreate.DefaultBranch unless ProjectCreate.InitializeWithReadme is true.
    • Project.ToClientProject() did not populate NameWithNamspace.
    • Project.FullName contains spaces around the slash separator.
  • Added tests to verify GitLab and Mock behaviors.

@belcher-rok
Add async IProjectClient methods
0652475 
Also improve the Mock ProjectClient to better emulate actual GitLab behavior.
@belcher-rok
Improve tests, fix bugs
4cae40b
@belcher-rok
Revert an unintentional change
1386b40
@belcher-rok belcher-rok requested a review from a team as a code owner April 4, 2024 00:58
@belcher-rok belcher-rok requested review from Toa741 and removed request for a team April 4, 2024 00:58
@belcher-rok
Copy link
Contributor Author

@Toa741 Anything I can do to help move this along?

@Toa741
Copy link
Contributor

Toa741 commented Apr 8, 2024

@Toa741 Anything I can do to help move this along?

Hey John :), I was on vacation, everything looks good, just had one question regarding the Project init in the mock

@belcher-rok belcher-rok force-pushed the belcher-projectclient-async branch from 50f5f00 to d636305 Compare April 9, 2024 21:43
@Toa741 Toa741 merged commit 1e153b9 into ubisoft:main Apr 10, 2024
4 checks passed
@belcher-rok belcher-rok deleted the belcher-projectclient-async branch April 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toa741 Toa741 Toa741 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belcher-rok @Toa741