Add async functions to IMembersClient and other changes #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use System.Net types in public APIs.
- Improve Create Group and Create User mock to better emulate GitLab. - Add support for explicit Group Path in mock helpers. - Add `RemoveMemberFrom*Async` and Implement async versions of the other Group and Project methods. - Add `IUserClient.GetByUserNameAsync` - Add unit and integrations tests to verify behavior of both the GitHub and Mock `IMembersClient`.
belcher-rok
commented
Mar 20, 2024
belcher-rok
commented
Mar 20, 2024
belcher-rok
commented
Mar 20, 2024
belcher-rok
commented
Mar 20, 2024
|
@louis-z Do you know why the list of commits in this PR includes all the commits from my previous PR? What am I not doing correctly? |
Toa741
reviewed
Mar 21, 2024
| @@ -158,8 +160,10 @@ public Models.User Update(int id, UserUpsert userUpsert) | |||
| var user = Server.Users.GetById(id); | |||
| if (user != null) | |||
| { | |||
| user.Name = userUpsert.Name; | |||
| user.Email = userUpsert.Email; | |||
| // user.UserName = userUpsert.Username ?? user.UserName; // TODO | |||
There was a problem hiding this comment.
Is there an reason of why the username can't be updated like the others?
There was a problem hiding this comment.
@Toa741 NGitLab.Mock.User.UserName is not settable. I assumed there is a reason for this, I just didn't have the time or need to investigate right now.
There are a few things to look out for:
|
|
Replaced by PR #652. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IUserClient.GetByUserNameAsyncRemoveMemberFrom*Asyncand Implement async versions of the other Group and Project methods.IMembersClient.