-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: setting up bun is unnecessary #49
base: development
Are you sure you want to change the base?
Conversation
Caution No labels are set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ubiquity-whilefoo/daemon-pull-review/actions/runs/13975625604/job/39128551650
Looks like it works, the only downside is that we can't control the version - its v20 currently and current LTS version is v22
Instead of checking out the repo, we should consider a |
Usually there are multiple files in the |
The point of ncc is to compile one file And also to bundle all dependencies of course |
I know but there are cases where it generates multiple files: https://github.com/ubiquity-os-marketplace/command-ask/tree/development/dist not sure if it actually uses them but there must be a reason |
Time for r&d |
The reason for it to generate multiple file, is that it happens when external package also include external code that gets referenced within that external library. We could try using Plus, you will have multiple files if you generate sourcemaps either way. And for ESM packages there will be a |
Resolves #50
I didn't test this because I'm not 100% of the syntax, but look how GitHub made their example for instant cold starts.
https://github.com/actions/typescript-action/blob/main/action.yml#L22-L24