-
Notifications
You must be signed in to change notification settings - Fork 1
Local build dockerfile #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alexr951
wants to merge
27
commits into
main
Choose a base branch
from
local_build_dockerfile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Alexr951
commented
Mar 31, 2025
- Added new notebook for local build of Comet on Windows + Mac
- Added a new base dockerfile which works on ARM64 and AMD64 (Currently the main dockerfile is running on my own Dockerhub not jlgraves, this will have to be changed at some point)
- Removed a line in Advanced/Network Analysis referencing a image called example_map.png which was breaking the build on Mac (not sure why as the file exists but something to look into).
- Added running_comet_locally.qmd from the other branch - Changed the base .docker image to hopefully work on Mac ARM64 CPU configurations.
Changes - Added --platform=linux/amd64 to tell Docker what platforms to target - Used both $TARGETARCH and uname -m for architecture detection - Removed fixed package versions that might cause issues - Added explicit copy of media and project directories
Got rid of line with example_map.png on Network Analysis 2 so that it does not throw an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.