Banner ads in body text on Modrinth and Curseforge #27026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those are unclickable so I'm not sure if it should be addressed. Better to report to EasyList anyways. @Yuki2718 What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More specific filters are needed as sometimes the banner ads don't include a link and need to be filtered differently. This filter uses the
alttext but other approaches may also be viable (such as using the text of the precedingh2, or both).URL(s) where the issue occurs
https://modrinth.com/mod/embeddiumhttps://www.curseforge.com/minecraft/mc-mods/embeddiumDescribe the issue
Banner ads in body text
Screenshot(s)
Versions
Settings
Notes
The
h2text preceding each of these ads is also technically part of the ad but I haven't found an easy way to include it in the filter without being overly broad. I'm open to suggestions and/or changes by maintainers to incorporate this.