Skip to content

remove errors.Is in tests #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rminnich merged 1 commit into from
Oct 22, 2025
Merged

remove errors.Is in tests #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vm/initramfs_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func TestInitRamfs(t *testing.T) {
}

b, err := vm.New("linux", "amd64")
if !errors.Is(err, nil) {
if err != nil {
t.Fatalf("Testing kernel=linux arch=amd64: got %v, want nil", err)
}

Expand Down
9 changes: 4 additions & 5 deletions vm/vm_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ package vm_test

import (
"context"
"errors"
"os"
"path/filepath"
"strings"
Expand All @@ -23,7 +22,7 @@ import (
func TestCPUAMD64(t *testing.T) {
d := t.TempDir()
i, err := vm.New("linux", "amd64")
if !errors.Is(err, nil) {
if err != nil {
t.Fatalf("Testing kernel=linux arch=amd64: got %v, want nil", err)
}

Expand Down Expand Up @@ -58,7 +57,7 @@ func TestCPUAMD64(t *testing.T) {
{cmd: "/bbin/dd", args: []string{"if=/tmp/cpu/a", "of=/tmp/cpu/b"}, ok: true},
} {
cpu, err := i.CPUCommand(tt.cmd, tt.args...)
if !errors.Is(err, nil) {
if err != nil {
t.Errorf("CPUCommand: got %v, want nil", err)
continue
}
Expand Down Expand Up @@ -110,7 +109,7 @@ func TestCPUAMD64(t *testing.T) {
func TestCPUARM(t *testing.T) {
d := t.TempDir()
i, err := vm.New("linux", "arm")
if !errors.Is(err, nil) {
if err != nil {
t.Fatalf("Testing kernel=linux arch=arm: got %v, want nil", err)
}

Expand Down Expand Up @@ -146,7 +145,7 @@ func TestCPUARM(t *testing.T) {
{cmd: "/bbin/dd", args: []string{"if=/tmp/cpu/a", "of=/tmp/cpu/b"}, ok: true},
} {
cpu, err := i.CPUCommand(tt.cmd, tt.args...)
if !errors.Is(err, nil) {
if err != nil {
t.Errorf("CPUCommand: got %v, want nil", err)
continue
}
Expand Down
Loading