Per review, default to not freeing buffers on flush

--- Signed-off-by: Michael Ferguson <[email protected]>
tzinsky · Feb 11, 2025 · 345b345 · 345b345
1 parent 93dc095
commit 345b345
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/modules/packages/CopyAggregation.chpl b/modules/packages/CopyAggregation.chpl
@@ -116,9 +116,7 @@ module CopyAggregation {
       if aggregate then agg.copy(dst, srcVal);
                    else dst = srcVal;
     }
-    inline proc ref flush(freeBuffers=true) {
-      // TODO: consider having no default or defaulting to 'false'
-
+    inline proc ref flush(freeBuffers=false) {
       if aggregate then agg.flush(freeBuffers=freeBuffers);
     }
   }
@@ -136,9 +134,7 @@ module CopyAggregation {
       if aggregate then agg.copy(dst, src);
                    else dst = src;
     }
-    inline proc ref flush(freeBuffers=true) {
-      // TODO: consider having no default or defaulting to 'false'
-
+    inline proc ref flush(freeBuffers=false) {
       if aggregate then agg.flush(freeBuffers=freeBuffers);
     }
   }