xkcdyst:0.1.0

[gelden324]

I am submitting

• a new package
• an update for a package

Description: pgf 'sketch' decoration reimplemented as a rust wasm plugin.

I have read and followed the submission guidelines and, in particular, I

• selected a name that isn't the most obvious or canonical name for what the package does
  • Explanation:
• added a typst.toml file with all required keys
• added a README.md with documentation for my package
• have chosen a license and added a LICENSE file or linked one in my README.md
• tested my package locally on my system and it worked
• excluded PDFs or README images, if any, but not the LICENSE

• ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

[elegaanz]

Can you please put your package in the correct subdirectory? See our docs on how to proceed. Also, build files should not be copied to this repository. Once this is done and the CI passes, I will have a deeper look.

[gelden324]

@elegaanz thank you ! File packages/preview/xkcdyst/0.1.0/typst.toml created. What’s next ? Sorry but I am a bit confused and have difficulty to find a simple way to submitting the package.

[elegaanz]

All file you added should be in that directory, not just the manifest. Also, the changes you made to the files with the same name at the root should be reverted.

[gelden324]

See now if everything is ok. Thank you

[elegaanz]

I don't see any changes. Maybe you forgot to push?

[gelden324]

@elegaanz Here github.com//pull/5552

[gelden324]

@elegaanz @saecki is it ok now ?

[elegaanz]

We're getting there, but there are still issues. First, build.sh should be removed, as it is a build file and is not necessary to run the plugin locally, sorry for missing that in the previous review. Then, the files at the root of the repository are still wrong. If you head the the "Changes" tab you can see in the file list that they were changed:

This should not be the case. You can revert the changes using the command I gave in my previous comment (if you use the Git command line) or just by deleting the current version of these files, and re-uploading what is on the main branch.

But your own version of the LICENSE and README files should still exist, in your package directory (packages/preview/xkcdyst/0.1.0).

To make things clear: there are two LICENSE/README files at play here. The ones at the root of the repository cover the whole package registry and the bundler program. The ones in your package directory are just for your package. The former should not be touched, and you should just upload the later.

[gelden324]

@elegaanz Thank you for your guidance. I made some changes. Please, see if it’s ok now.

[elegaanz]

Sorry, but it is still not correct. I would advise getting help from more experienced users, either on the Typst Forum, the Discord server or IRL if you know people who are familiar with Git and GitHub.