underhell:0.2.0 - #5497
Open
CrossDark wants to merge 2 commits into
Open
Conversation
elegaanz
reviewed
Aug 10, 2026
| entrypoint = "lib.typ" | ||
| authors = ["Colin Jacobs", "跨越晨昏"] | ||
| license = "MIT" | ||
| description = "用于创建龙与地下城 5E 内容,包括冒险、属性方块、法术卡。" |
Member
There was a problem hiding this comment.
Having the description in English would be appreciated, in particular if the package is not limited to a Chinese-speaking audience.
Member
There was a problem hiding this comment.
Same for the README, having at least the introduction paragraph translated to English would be nice.
| keywords = ["roleplaying", "dnd", "dungeons-dragons", "rpg", "template", "gaming"] | ||
| categories = ["layout", "report"] | ||
| compiler = "0.13.0" | ||
| exclude = ["example"] |
Member
There was a problem hiding this comment.
I'm not sure why this directory exists in the first place. It can make sense in your own repository, but since you don't link to it from your README and don't need these files for the package to run, there is no point in copying these files here. Can you either:
- link to the example files in your README
- transform this directory into a template
- or remove it entirely.
saecki
reviewed
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE