Skip to content

Conversation

fepfitra
Copy link

@fepfitra fepfitra commented Oct 1, 2025

I am submitting

  • a new package
  • an update for a package

Description: Sheen.id editing template for internal usage

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Oct 1, 2025
@saecki saecki self-assigned this Oct 6, 2025
Copy link
Member

@saecki saecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this package! I've left a few comments, regarding the package name and description, and how image paths are currently handled.

)

// 3. Set global images (optional)
#set-chapter-image("path/to/chapter-default.png")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the paths here won't work properly (even with the use of context), because paths are package scoped. Instead a common approach is to accept the content here directly, so users would have to pass image("<path>") instead. This also makes the template more flexible, since any kind of content can be used.

@@ -0,0 +1,14 @@
[package]
name = "sheen-id"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use sheen-id as a package name we need to verify that you are affiliated with sheen.id. Could you send an email from your company email to [email protected] endorsing this package?

@saecki saecki added the waiting-on-author Pull request waits on author label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new A new package submission. waiting-on-author Pull request waits on author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants