-
Notifications
You must be signed in to change notification settings - Fork 728
sheen-id:0.1.0 #3169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
sheen-id:0.1.0 #3169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this package! I've left a few comments, regarding the package name and description, and how image paths are currently handled.
) | ||
|
||
// 3. Set global images (optional) | ||
#set-chapter-image("path/to/chapter-default.png") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the paths here won't work properly (even with the use of context
), because paths are package scoped. Instead a common approach is to accept the content here directly, so users would have to pass image("<path>")
instead. This also makes the template more flexible, since any kind of content can be used.
@@ -0,0 +1,14 @@ | |||
[package] | |||
name = "sheen-id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use sheen-id
as a package name we need to verify that you are affiliated with sheen.id
. Could you send an email from your company email to [email protected] endorsing this package?
I am submitting
Description: Sheen.id editing template for internal usage
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE