biblatex type
to genre
, number
to serial
for non-article.
#296
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to close #295 :
The
type
field (not entry type) in biblatex is used to setgenre
, regardless of entry type. I think this is appropriate for all uses oftype
; biblatex's documentation statestype
is "The type of a manual, patent, report, or thesis. This field may also be useful for the custom types listed in § 2.1.3.", while Hayagriva's file format statesgenre
is "Type, class, or subtype of the item (e.g. "Doctoral dissertation" for a PhD thesis; "NIH Publication" for an NIH technical report). Do not use for topical descriptions or categories (e.g. "adventure" for an adventure movie).".The
number
field is more of a problem. Biblatex's documentation describes it as "The number of a journal or the volume/number of a book in a series." However, it then goes on to say "With@patent
entries, this is the number or record token of a patent or patent request", and, not documented in the description ofnumber
, is listed as an optional field in several entry types that seem more likely to be using it as a CSL number / Hayagriva serial-number than an issue number, namely report, manual, and dataset. So I'm not quite sure what the best handling here is.I've done what seems to be to be the minimal change, which is to set serial-number for Repository, Reference, Patent, and Report, the Hayagriva types corresponding to the biblatex types that list number as an optional field where serial-number seems to make more sense. But I wonder whether non-default styles also use it for other types, eg, Manuscript, Thesis, etc?