Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use roman-numerals-rs #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AA-Turner
Copy link

The numerals crate was last updated five years ago, this PR adopts a no-std / 0BSD crate that is also faster.

roman-numerals-rs implements TryFrom, so the match construct can be simplified (at the cost of minor duplication).

A

@AA-Turner
Copy link
Author

None of the lint or test failures seem related to this PR:

error: rustc 1.80.0 is not supported by the following packages:
  [email protected] requires rustc 1.81
  [email protected] requires rustc 1.81
failures:

---- always_archive stdout ----

thread 'always_archive' panicked at tests/archiver.rs:117:73:
called `Result::unwrap()` on an `Err` value: Custom("unknown variant `page`, expected one of `chapter-number`, `citation-number`, `collection-number`, `edition`, `first-reference-note-number`, `issue`, `locator`, `number`, `number-of-pages`, `number-of-volumes`, `page-first`, `part-number`, `printing`, `printing-number`, `section`, `supplement-number`, `version`, `volume`")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    always_archive

@PgBiel PgBiel force-pushed the roman-numerals-rs branch from 34b7dd7 to 50855f6 Compare March 7, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant