Skip to content

feat(typescript-estree): private identifiers can only appear on LHS of in expressions #9232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1dc3d06
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665df4534bf34d0008457573
😎 Deploy Preview https://deploy-preview-9232--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Josh-Cena Josh-Cena marked this pull request as draft June 3, 2024 17:14
@Josh-Cena
Copy link
Member Author

Converting it to draft, because TS is very wack about private identifiers: console.log(#a) is also valid.

@JoshuaKGoldberg
Copy link
Member

👋 just checking in @Josh-Cena, is there anything we should do with this?

@JoshuaKGoldberg
Copy link
Member

Chatted 1:1, this is blocked on a resolution to microsoft/TypeScript#58754.

@JoshuaKGoldberg JoshuaKGoldberg added the blocked by another issue Issues which are not ready because another issue needs to be resolved first label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by another issue Issues which are not ready because another issue needs to be resolved first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AST tightening: PrivateIdentifier can only be LHS of BinaryExpression[operator='in']
2 participants