-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(typescript-estree): private identifiers can only appear on LHS of in expressions #9232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(typescript-estree): private identifiers can only appear on LHS of in expressions #9232
Conversation
Thanks for the PR, @Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Converting it to draft, because TS is very wack about private identifiers: |
👋 just checking in @Josh-Cena, is there anything we should do with this? |
Chatted 1:1, this is blocked on a resolution to microsoft/TypeScript#58754. |
PR Checklist
PrivateIdentifier
can only be LHS ofBinaryExpression[operator='in']
#9222Overview