Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified a few issues in the existing tests that this PR fixes:
CodePointMappercan return strings that are not canonicalized whereas icu4j, as part of further IDNA processing, returns canonicalized strings -- e.g.,"궈ㄻ"is returned as code points[44424, 4529]whereas icu4j returns44434. This was fixed by adding an additional NFC normalization in the test suite.java.text.Normalizerand icu4j when dealing with undefined unicode characters -- e.g., given the string "\u0360\u1ac6",Normalizerdoes not treat the undefined character\u1ac6as a diacritic despite being in a block reserved for diacritics, whereasNormalizer2does. This was fixed by adding a check for undefined characters when asserting equivalence.This PR also addresses a few issues with the build structure: