Skip to content

ignore read ECONNRESET err #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ignore read ECONNRESET err #946

wants to merge 1 commit into from

Conversation

f-w
Copy link

@f-w f-w commented Sep 13, 2025

@f-w f-w requested review from nodkz and hasezoey as code owners September 13, 2025 18:26
hasezoey
hasezoey reviewed Sep 14, 2025
View reviewed changes
Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did you already have a chance to test this?

hasezoey
hasezoey reviewed Sep 14, 2025
View reviewed changes
packages/mongodb-memory-server-core/src/util/MongoInstance.ts
Comment on lines +466 to +467
/^connection \d+ to [\d.]+:\d+ closed$/i.test(err.message) ||
'read ECONNRESET' === err.message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/^connection \d+ to [\d.]+:\d+ closed$/i.test(err.message) ||
'read ECONNRESET' === err.message
(/^connection \d+ to [\d.]+:\d+ closed$/i.test(err.message) ||
'read ECONNRESET' === err.message)

To make use of the typescript check that message exists; or is it not a MongoNetworkError?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It's not MongoNetworkError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey left review comments

@nodkz nodkz Awaiting requested review from nodkz nodkz is a code owner

+1 more reviewer

@abbr abbr abbr left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-w @abbr @hasezoey