Skip to content

Update MyPy max pinned version to 0.782 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update MyPy max pinned version to 0.782 #87

wants to merge 1 commit into from

Conversation

sidmitra
Copy link

  • The latest version of MyPy is 0.782 here

@sidmitra
Copy link
Author

I've been using the latest master with 0.782 for the past few weeks and everything seems to work correctly.

@sidmitra
Copy link
Author

Will try to take a look at the CI error later today. Not sure if it's related to the PR.

$ mypy -p rest_framework-stubs
rest_framework-stubs/request.pyi: error: Source file found twice under different module names: 'rest_framework-stubs.request' and 'rest_framework.request'  [misc]
Found 1 error in 1 file (checked 48 source files)
The command "mypy -p rest_framework-stubs" exited with 2.

@sobolevn
Copy link
Member

Yes, this is known bug in the latest mypy. That's why I had to pin it to the previous version. See python/mypy#8944

@sidmitra
Copy link
Author

@sobolevn Thanks for the link, wasn't aware of that. I didn't come across any issues on our production codebase. I will take a deeper look, looks more involved though.

@Goldziher
Copy link
Member

This PR can be closed @sobolevn

@sobolevn sobolevn closed this Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants