feat(icon-button): add new pressed property/attribute and deprecate on property
#817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRiFTy17
added
minor
|
|
samrichardsontylertech
previously approved these changes
Feb 7, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
The icon-button currently supports an
onproperty, and when we started Forge v3 we introducedoninstead ofisOnfrom v2 thinking it would give more semantic meaning and consistency, but we've learned that frameworks such as Angular do not place nice with this naming...We are going to now deprecate the
onproperty in favor ofpressed(which mimics thearia-pressedstate) and this PR addresses that change.