Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing access tokens on demand #308

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Refreshing access tokens on demand #308

merged 5 commits into from
Jan 15, 2024

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Jan 4, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Adding a feature to refresh access tokens via the CLI.
Resolves #307

Description of Changes:

  • Added --refresh flag to twitch token, allowing users to refresh their access tokens.
  • Added --secret flag to twitch token, allowing users to override the Client Secret as it currently defaults to the one in the config.
  • Moved error handling and messaging for token and login stuffs upstream out of login.go and into callers like token.go

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

Copy link
Contributor

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, like how you the error handling is

@Xemdo Xemdo merged commit 2893a58 into main Jan 15, 2024
8 checks passed
@Xemdo Xemdo deleted the feat-307 branch January 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Implement usage of Refresh Token
2 participants