Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include @types/events in the install command #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MohammedHS404
Copy link

I took me sometime to realize that I couldn't listen on the device/call events because my React app didn't recognize the EventEmitter as a type because it's a js node library.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

A description of what this PR does.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Ready for review

Before merge

  • Got one or more +1s
  • Squashed erroneous commits if necessary
  • Re-tested if necessary

Sorry, something went wrong.

I took me sometime to realize that I couldn't listen on the device/call events because my React app didn't recognize the EventEmitter as a type because it's a js node library.
@kpchoy
Copy link
Collaborator

kpchoy commented Feb 27, 2025

@MohammedHS404 Thanks for the PR request. However, since not all users will be using typescript, I think it would be unnecessary for them to add this package. Let me know if you have different reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants