Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(twilio-run): turn off fork-process in inspect mode #462

Merged
merged 3 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/warm-moles-learn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'twilio-run': patch
'@twilio-labs/plugin-serverless': patch
---

Fix of debug/inspect mode by disabling fork process
14 changes: 14 additions & 0 deletions packages/twilio-run/__tests__/config/start.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -285,4 +285,18 @@ describe('getConfigFromCli', () => {
expect(startConfig.baseDir).toEqual(path.resolve(config.cwd));
}
});

test('turns off fork process if inspect is enabled', async () => {
require('../../src/config/utils/package-json').__setPackageJson({});
const config = {
dir: './other_dir',
inspect: '',
} as unknown as StartCliFlags;
if (config.dir) {
const startConfig = await getConfigFromCli(config);
expect(startConfig.baseDir).toEqual(path.resolve(config.dir));
expect(startConfig.forkProcess).toEqual(false);
expect(startConfig.inspect).not.toEqual(undefined);
}
});
});
6 changes: 6 additions & 0 deletions packages/twilio-run/src/config/start.ts
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,12 @@ export async function getConfigFromCli(
config.assetsFolderName = cli.assetsFolder;
config.functionsFolderName = cli.functionsFolder;
config.forkProcess = cli.forkProcess;

if (typeof config.inspect !== 'undefined') {
debug('Disabling fork-process in inspect mode.');
config.forkProcess = false;
}

config.pkgJson = pkgJson;

return config;
Expand Down
Loading