Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust for Web: Lettuce Crop (+ AWS Lambda) #138

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

michielp1807
Copy link
Collaborator

No description provided.

@squell squell requested a review from tdittr March 4, 2025 11:08
Copy link
Collaborator

@tdittr tdittr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally found the time to read through these. I think they are excellent! Great job. I only found a few nit-picks.

I have not yet tried the exercises, still need to do that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the license to use this vegetable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the original came from this website, which says it should be CC0 public domain. I edited the image a bit and made the background transparent myself.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some more reverse image searching, I tracked it back to this seemingly slightly more reputable website, which lists it under a free non-commercial license

Copy link
Collaborator

@squell squell Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes you think the second link is the "more original" source? I'm also quite sure Tamme or I could produce an original photograph of a lettuce if we can't find an image we like (this photo is a damn fine example of a lettuce crop) and are sure is CC0 (or at least, CC-BY-SA compatible)

Copy link
Collaborator Author

@michielp1807 michielp1807 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think the first website is the original source anyways, as you can see the author's full profile here as mentioned in this blog post

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added image attribution in the file crop.txt, I think that should be more than sufficient given that the image is licensed CC0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants