🎨 Dark mode when user prefers dark mode #102
Conversation
|
Acknowledge on the wish of "dark mode". The first attempt to implement it, should be discarded. |
backend/src/main.rs
Outdated
There was a problem hiding this comment.
These removals of empty lines are NOT related to dark mode change.
There was a problem hiding this comment.
my bad, had some logs there 👍
There was a problem hiding this comment.
The replacing of ' with " pollutes the dark mode commit.
There was a problem hiding this comment.
my bad too, I have a default formatter across the board should be fine now
|
On Sun, Sep 10, 2023 at 01:24:50AM -0700, Geert Stappers wrote:
@stappersg commented on this pull request.
On frontend/style.scss:
The replacing of `'` with `"` pollutes the dark mode commit.
Replacing "empty lines that are separators to improve readability"
with new CSS lines should be just adding new CSS lines.
Groeten
Geert Stappers
--
Silence is hard to parse
|
|
Use another icon as trash can for the |
so just discard it and reimplement? |
noticed that too, so I just removed the icon all together. I can put in a little sun or something |
|
On Sun, Sep 10, 2023 at 01:52:50AM -0700, Alek Angelov wrote:
On Sun, Sep 10, 2023 at 01:12:50AM -0700, Geert Stappers wrote:
>
> The first attempt to implement it, should be discarded.
so just discard it and reimplement?
Too late
|
just do it |
|
Make another commit to avoid pollution of this merge request. https://github.com/tweedegolf/mailcrab/pull/102/files currently shows
|
|
squashed the commits, should be 1 commit now with ' instead of " and all the changes requested |
|
On Sun, Sep 10, 2023 at 06:30:50AM -0700, Alek Angelov wrote:
squashed the commits, should be 1 commit
Acknowledge.
What about a commit message?
now with ' instead of "
Ack
and all the changes requested
No, that is (currently) not true.
Groeten
Geert Stappers
--
Silence is hard to parse
|
|
On Sun, Sep 10, 2023 at 07:02:06AM -0700, Geert Stappers wrote:
On Sun, Sep 10, 2023 at 06:30:50AM -0700, Alek Angelov wrote:
> squashed the commits, should be 1 commit
Acknowledge.
What about a commit message?
> and all the changes requested
No, that is (currently) not true.
@marlonbaeten please postpone merging this feature.
For various reasons:
* #103 should go first (and this MR rebased)
* there are pending changes
* lack of a commit message
Groeten
Geert Stappers
--
Silence is hard to parse
|
|
why in god's name would you offend me this makes absolutely no sense, im literally just trying to help out the hostility here is insane calling anybody that tries to chip in to something that is absolutely insane |
f this, i wont be called that for literally trying to contribute to something |
|
@alekangelov thank you for this! I will merge your work this morning and release it in version 0.22 Sorry for being late to respond to your PR - your work is very much appreciated! @stappersg please be more welcoming to any contributions, and more friendly to their contributors. I think your trying to help to keep the commit history clean, but in the end it's for me to decide what to merge. I value an open and friendly environment for any contributions way more than a clean commit history. |
|
Merged together with #104 |
Rethink that.
My point of view: I did see a fresh idea (switching light mode dark mode) with lots of fresh paint, rough edges and other signs of a hasty release.
Illustrated by the re-opening of a revoked merge request. |
Tired of getting blasted with light at night tbh
cheers
added a button that inverts the body