github: Build the Windows CI job with the MSVC toolchain#2242
Merged
Conversation
penberg
force-pushed
the
windows-ci
branch
6 times, most recently
from
12a9b00 to
59f9833
Compare
penberg
changed the title
The Windows job's `cargo build -p libsql --all-features` was being built with the `x86_64-pc-windows-gnu` toolchain (MinGW/GCC), set as the default host triple by `hecrj/setup-rust-action@v2`. MSVC was never exercised. So breaks that only fail under MSVC -- like the SQLite 3.47.0 `#warning` that errors with C1021 -- compiled green here. We discovered the gap when libsql-js (which builds with `--target x86_64-pc-windows-msvc`) failed downstream on the same code. Add `--target x86_64-pc-windows-msvc --release` so the Windows job actually compiles the bundled SQLite encryption amalgamation (sqlite3mc) with MSVC, and breaks surface in CI. `cargo clean -p libsql-ffi` runs first so sqlite3mc is rebuilt from source rather than restored from a cached target/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows job's
cargo build -p libsql --all-featureswas being built with thex86_64-pc-windows-gnutoolchain (MinGW/GCC), set as the default host triple byhecrj/setup-rust-action@v2. MSVC was never exercised. So breaks that only fail under MSVC -- like the SQLite 3.47.0#warningthat errors with C1021 -- compiled green here. We discovered the gap when libsql-js (which builds with--target x86_64-pc-windows-msvc) failed downstream on the same code.Add
--target x86_64-pc-windows-msvc --releaseso the Windows job actually compiles the bundled SQLite encryption amalgamation (sqlite3mc) with MSVC, and breaks surface in CI.cargo clean -p libsql-ffiruns first so sqlite3mc is rebuilt from source rather than restored from a cached target/.