libsql-sqlite3: Skip SQLITE_USER_AUTHENTICATION #warning on MSVC#2241
Merged
Conversation
The SQLITE_USER_AUTHENTICATION deprecation #warning (added upstream in SQLite 3.46.0) is a hard error under MSVC's default traditional C preprocessor (error C1021: invalid preprocessor command 'warning'), breaking Windows builds. SQLite3MultipleCiphers force-enables SQLITE_USER_AUTHENTICATION by default, so the directive is active even though build.rs passes -DSQLITE_USER_AUTHENTICATION=OFF. Guard the directive with !defined(_MSC_VER) so the deprecation notice is kept for GCC/Clang and skipped on MSVC. This is purely a compile-time diagnostic; the extension's runtime behavior is unchanged on all platforms. Upstream removed this extension entirely in SQLite 3.48.0 (commit bc4df60), so this local patch becomes moot once the bundled SQLite is updated past 3.47.0. The patch is applied in libsql-sqlite3/src and mirrored into both regenerated bundled amalgamations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQLITE_USER_AUTHENTICATION deprecation #warning (added upstream in SQLite 3.46.0) is a hard error under MSVC's default traditional C preprocessor (error C1021: invalid preprocessor command 'warning'), breaking Windows builds. SQLite3MultipleCiphers force-enables SQLITE_USER_AUTHENTICATION by default, so the directive is active even though build.rs passes -DSQLITE_USER_AUTHENTICATION=OFF.
Guard the directive with !defined(_MSC_VER) so the deprecation notice is kept for GCC/Clang and skipped on MSVC. This is purely a compile-time diagnostic; the extension's runtime behavior is unchanged on all platforms.
Upstream removed this extension entirely in SQLite 3.48.0 (commit bc4df60), so this local patch becomes moot once the bundled SQLite is updated past 3.47.0. The patch is applied in libsql-sqlite3/src and mirrored into both regenerated bundled amalgamations.