Replace per-connection execution lock with statement-level interrupts#226
Merged
Conversation
penberg
force-pushed
the
query-timeout-overhead
branch
2 times, most recently
from
b6e1f9b to
24be2ba
Compare
Query timeouts previously relied on a per-connection execution lock that serialized every operation so the timer wheel's connection.interrupt() would unambiguously hit the timed-out operation. This serialized all concurrent work on a connection and added a mutex acquisition to every call. Use libsql_stmt_interrupt() instead: the timer wheel now interrupts the specific statement that timed out (via a new Interruptible trait, so the wheel can target either a statement or a connection), leaving other concurrent operations on the same connection untouched. This removes execution_lock entirely, along with acquire_execution_lock and the deadline/remaining plumbing it required. Depends on: tursodatabase/libsql#2248
penberg
force-pushed
the
query-timeout-overhead
branch
from
24be2ba to
368a962
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query timeouts previously relied on a per-connection execution lock that
serialized every operation so the timer wheel's connection.interrupt() would
unambiguously hit the timed-out operation. This serialized all concurrent work
on a connection and added a mutex acquisition to every call.
Use libsql_stmt_interrupt() instead: the timer wheel now interrupts the
specific statement that timed out (via a new Interruptible trait, so the wheel
can target either a statement or a connection), leaving other concurrent
operations on the same connection untouched. This removes execution_lock
entirely, along with acquire_execution_lock and the deadline/remaining
plumbing it required.
Depends on: tursodatabase/libsql#2248