feaat: top 5 links can now filter by multiple links

turingschool · Sep 13, 2024 · 0ff94f8 · 0ff94f8
1 parent d1311d2
commit 0ff94f8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/controllers/api/v1/links_controller.rb b/app/controllers/api/v1/links_controller.rb
@@ -29,7 +29,11 @@ def show
   def top_links
     query = Link.where(private: false).order(click_count: :desc).limit(5)
 
-    query = query.joins(:tags).where(tags: { name: params[:tag] }) if params[:tag].present?
+    if params[:tag].present?
+      tags = params[:tag].split(',').map(&:strip)
+      query = query.joins(:tags).where(tags: { name: tags })
+      query = query.group('links.id').having('COUNT(DISTINCT tags.id) = ?', tags.size)
+    end
 
     links = query.distinct
 

diff --git a/dump.rdb b/dump.rdb
diff --git a/spec/requests/api/v1/links_request_spec.rb b/spec/requests/api/v1/links_request_spec.rb
@@ -241,7 +241,7 @@
       links = JSON.parse(response.body, symbolize_names: true)[:data]
 
       expect(links.count).to eq(2)
-      expect(links[0][:attributes][:click_count]).to eq)
+      expect(links[0][:attributes][:click_count]).to eq(100)
       expect(links.last[:attributes][:click_count]).to eq(50)
     end
   end