Bump TerminalGuiVersion to 2.4.18-develop.27 (needs fixes) - #281
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a2b05ec10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.5</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.27</TerminalGuiVersion> |
There was a problem hiding this comment.
Keep the default pin on a validated Terminal.Gui release
When consumers or CI build without overriding TerminalGuiVersion, this line resolves the known-incompatible 2.4.18-develop.27 package. The bump workflow's restore/build/test validation already failed and the commit explicitly states that Editor source fixes are required, but this change contains none, so merging it leaves the repository's default build or test suite red; retain the previous pin until the compatibility fixes and validation are included.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
Automated bump of
TerminalGuiVersionfrom2.4.18-develop.5to2.4.18-develop.27failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.