Skip to content

Small backprop optimization, fix gym.h #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small backprop optimization, fix gym.h #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gym.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ void gym_nn_image_grayscale(NN nn, void *pixels, size_t width, size_t height, si
float a = ROW_AT(NN_OUTPUT(nn), 0);
if (a < low) a = low;
if (a > high) a = high;
uint32_t pixel = (a + low)/(high - low)*255.f;
uint32_t pixel = (a - low)/(high - low)*255.f;
pixels_u32[y*stride + x] = (0xFF<<(8*3))|(pixel<<(8*2))|(pixel<<(8*1))|(pixel<<(8*0));
}
}
Expand Down
15 changes: 2 additions & 13 deletions nn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,9 +400,9 @@ NN nn_backprop(Region *r, NN nn, Mat t)

for (size_t j = 0; j < out.cols; ++j) {
#ifdef NN_BACKPROP_TRADITIONAL
ROW_AT(NN_OUTPUT(g), j) = 2*(ROW_AT(NN_OUTPUT(nn), j) - ROW_AT(out, j));
ROW_AT(NN_OUTPUT(g), j) = 2.0f/n*(ROW_AT(NN_OUTPUT(nn), j) - ROW_AT(out, j));
#else
ROW_AT(NN_OUTPUT(g), j) = ROW_AT(NN_OUTPUT(nn), j) - ROW_AT(out, j);
ROW_AT(NN_OUTPUT(g), j) = 1.0f/n*(ROW_AT(NN_OUTPUT(nn), j) - ROW_AT(out, j));
#endif // NN_BACKPROP_TRADITIONAL
}

Expand Down Expand Up @@ -430,17 +430,6 @@ NN nn_backprop(Region *r, NN nn, Mat t)
}
}

for (size_t i = 0; i < g.arch_count-1; ++i) {
for (size_t j = 0; j < g.ws[i].rows; ++j) {
for (size_t k = 0; k < g.ws[i].cols; ++k) {
MAT_AT(g.ws[i], j, k) /= n;
}
}
for (size_t k = 0; k < g.bs[i].cols; ++k) {
ROW_AT(g.bs[i], k) /= n;
}
}

return g;
}

Expand Down