update ecs ec2 CF to support code executor #229
Conversation
avimoondra
force-pushed
the
avimoondra/update-ecs-ec2-cf-with-ce
branch
from
ff6afab to
6957890
Compare
| @@ -377,7 +430,7 @@ Resources: | |||
| AllocatedStorage: "80" | |||
| DBInstanceClass: "db.m5.large" | |||
| Engine: postgres | |||
| EngineVersion: "13.11" | |||
There was a problem hiding this comment.
Template does not work as is
Cannot find version 13.11 for postgres (Service: Rds, Status Code: 400, Request ID: c2a95d82-78f1-46b6-9473-148f47f5f0ad)
| @@ -846,8 +931,6 @@ Resources: | |||
| Value: temporal.retoolsvc:7233 | |||
| - Name: ECS_DEPLOYED | |||
| Value: "true" | |||
| - Name: WORKFLOW_BACKEND_HOST | |||
| Value: http://workflows-backend.retoolsvc:3000 | |||
There was a problem hiding this comment.
irrelevant to set in temporal services
| ImageCodeExecutor: | ||
| Type: String | ||
| Description: Image to use in the Code Executor Service | ||
| Default: tryretool/code-executor-service:3.114.7-stable |
There was a problem hiding this comment.
what do you think of something like the below? would make version mismatches much less likely, but also one-off images from other repos become a bit harder to use.
Type: String
Description: Retool version tag
Default: 3.114.7-stable
ContainerImage: !Sub tryretool/backend:${Version}
CodeExecutorImage: !Sub tryretool/code-executor-service:${Version}
There was a problem hiding this comment.
Yes, I like this a lot. Tbh I feel like one offs are less common these days (probably for the better)
There was a problem hiding this comment.
If we are getting to a one off we might be pretty hands on anyways. The workaround I guess is they'd have to update the template alongside the one off.
| @@ -492,7 +545,7 @@ Resources: | |||
| MinimumHealthyPercent: !Ref 'MinimumHealthyPercent' | |||
| TaskDefinition: !Ref 'RetoolWorkflowsWorkerTask' | |||
|
|
|||
| RetoolWorkkflowsBackendECSService: | |||
| RetoolWorkflowsBackendECSService: | |||
There was a problem hiding this comment.
thanks for fixing typo. not too familiar with AWS CF change management and ordering of operations, but this may lead to some downtime if the old service is torn down before the new one is brought up?
There was a problem hiding this comment.
Between this and the RDS change, I feel like it's still worth it for all new customers using the template at least (more polish).
For most resources, changing the logical name of a resource is equivalent to deleting that resource and replacing it with a new one. Any other resources that depend on the renamed resource also need to be updated and might cause them to be replaced. Other resources require you to update a property (not just the logical name) in order to initiate an update.
(as expected)
update ecs ec2 CF to support code executor
Create ECS Ec2 cluster in VPC, capacity provider specs: