fix: remove index.knn.space_type setting

[dandeto]

This "index.knn.space_type" setting is no longer available in opensearch 3. Rather than creating the index, it throws an exception. Cosine Similarity was already being specified in the mapping, so the setting was not required in older versions anyway. I removed the offending line to restore functionality for version 3 of opensearch.

Summary by CodeRabbit

• Refactor

  • Simplified OpenSearch vector index configuration by relying on the default KNN space type while preserving cosine similarity behavior.
  • Reduced explicit settings to streamline setup and maintenance.

• Chores

  • Minor configuration cleanup with no impact on APIs or public interfaces.

• Notes

  • No user-facing changes expected; existing collections and search behavior remain the same.
  • Stability and performance characteristics should be unaffected.

[coderabbitai]

Walkthrough

Removed the explicit index.knn.space_type="cosinesimil" from CreateCollectionAsync’s index creation in OpenSearchVectorDatabase.cs, leaving index.knn enabled and vector mapping unchanged. The index now relies on the default KNN space type. No public API signatures or control flow were altered.

Changes

Cohort / File(s)	Summary
OpenSearch index configuration src/OpenSearch/src/OpenSearchVectorDatabase.cs	Removed explicit index.knn.space_type ("cosinesimil") from index creation; retained index.knn=true and existing vector mapping. Logic and error handling unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge a knob, just one small spin,
From “cosinesimil” to default within.
Indices hum, vectors align,
I twitch my ears—config is fine.
Hop, hop—less is more, I grin,
A lighter burrow for data to begin. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 17b8b9e and 43a1c09.

📒 Files selected for processing (1)

• src/OpenSearch/src/OpenSearchVectorDatabase.cs (0 hunks)

💤 Files with no reviewable changes (1)

• src/OpenSearch/src/OpenSearchVectorDatabase.cs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and test / Build, test and publish

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dandeto]

Hey @HavenDV Looks like the build ci/cd failed to push the new nuget package. Could you please fix that when you have a chance?