Skip to content

feat: allow user to provide client for OpenSearchVectorDatabase #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HavenDV merged 2 commits into from
Apr 8, 2025
+11 −2
Merged

feat: allow user to provide client for OpenSearchVectorDatabase #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53d8e3c
feat: Allow user to provide client for OpenSearchVectorDatabase
daniel-jdm Apr 8, 2025
6e02b7a
fix: switch OpenSearchClient to IOpenSearchClient
daniel-jdm Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenSearch/src/OpenSearchVectorCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace LangChain.Databases.OpenSearch;
/// Represents a vector collection using OpenSearch.
/// </summary>
public class OpenSearchVectorCollection(
OpenSearchClient client,
IOpenSearchClient client,
string name,
string id) : VectorCollection(name, id), IVectorCollection
{
Expand Down
11 changes: 10 additions & 1 deletion src/OpenSearch/src/OpenSearchVectorDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace LangChain.Databases.OpenSearch;
/// </summary>
public class OpenSearchVectorDatabase : IVectorDatabase
{
private readonly OpenSearchClient _client;
private readonly IOpenSearchClient _client;

/// <summary>
/// Initializes a new instance of the <see cref="OpenSearchVectorDatabase"/> class.
Expand All @@ -25,6 +25,15 @@ public OpenSearchVectorDatabase(OpenSearchVectorDatabaseOptions? options = null)
_client = new OpenSearchClient(settings);
}

/// <summary>
/// Initializes a new instance of the <see cref="OpenSearchVectorDatabase"/> class.
/// </summary>
/// <param name="client">The OpenSearch client.</param>
public OpenSearchVectorDatabase(IOpenSearchClient client)
{
_client = client;
}

/// <inheritdoc />
public async Task CreateCollectionAsync(string collectionName, int dimensions, CancellationToken cancellationToken = default)
{
Expand Down
Loading