Calculate correct content length for UTF-8 string #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using `Content-Length: request.length`, you risk telling the server the wrong byte‐count. Consider this payload:
```
const response = await client.registerAccount({
Firstname: "Christöffer",
Lastname: "Skeppstedt",
...
});
```
When the string contains an "ö" instead of "o", we have:
- Byte count: 930
- String length: 929
When this request is sent to the Trustly API, it responds back with:
```
{
"name": "JSONRPCError",
"code": 101,
"message": "ERROR_MALFORMED_JSON"
}
```
This is likely because the content length header is incorrect. When instead using `Content-Length: Buffer.byteLength(request, 'utf8')`, the request is accepted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
Content-Length: request.length, you risk telling the server the wrong byte‐count. Consider this payload:When the string contains an "ö" instead of "o", we have:
When this request is sent to the Trustly API, it responds back with:
{ "name": "JSONRPCError", "code": 101, "message": "ERROR_MALFORMED_JSON" }This is likely because the content length header is incorrect (929 != 930). When instead using
Content-Length: Buffer.byteLength(request, 'utf8'), we get the correct content lenght, and the request is accepted.