Replace string.c with optional tinyrlibc feature and release v0.4.0#35
Merged
Conversation
As discussed in #15, we should support situations where the functions from string.c are provided by a different crate too. This patch removes string.c alltogether and adds an optional tinyrlibc feature to pull in the functions that were previously provided by string.c from tinyrlibc.
sosthene-nitrokey
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #15, we should support situations where the functions from string.c are provided by a different crate too. This patch removes string.c altogether and adds an optional tinyrlibc feature to pull in the functions that were previously provided by string.c from tinyrlibc.
We could try to make this a compatible change by adding it to the default features, but I think it makes more sense to make it a breaking change and use the occasion to do minor releases of littlefs2-sys and littlefs2 before the trussed v0.2 release.