NAS-134717 / 25.10 / Allow specifying image OS for virt VMs #16228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
anodos325
reviewed
Apr 9, 2025
| @@ -274,6 +277,9 @@ def __data_to_config(self, instance_name: str, data: dict, raw: dict = None, ins | |||
| config['user.autostart'] = str(data['autostart']).lower() | |||
|
|
|||
| if instance_type == 'VM': | |||
| if data.get('image_os'): | |||
| config['image.os'] = data['image_os'].capitalize() | |||
There was a problem hiding this comment.
Is this clearly defined somewhere in incus specs/docs that we can use it this way? Should we be using user.ix_image_os instead?
There was a problem hiding this comment.
It is documented here https://github.com/lxc/incus/pull/1767/files
We are investigating upgrading incus version as well and that should hopefully pull this fix in too when that happens
There was a problem hiding this comment.
Specifically this part
When creating a Windows virtual machine, make sure to set the `image.os` property to something starting with `Windows`.
Doing so will tell Incus to expect Windows to be running inside of the virtual machine and to tweak behavior accordingly.
anodos325
reviewed
Apr 9, 2025
|
@Qubad786 friendly ping |
anodos325
approved these changes
Apr 22, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
RTC for incus VMs are by default set to UTC, which is fine for linux base VMs but it is problematic for Windows VMs because Windows requires RTC to be set to
localtimein order to work correctly. To resolve this, it is required thatimage.osproperty is set toWindows, by doing this, incus will set rtc to localtime internally.This PR introduces a
image_osfield which a user can specify at the time of creating an instance or updating it. We specify a few popular OS choices but let the user specify anything else he might want as well.