add support for TARGET_DEVICE parameter #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atobiszei
reviewed
Apr 17, 2025
Comment on lines
+321
to
+323
| std::transform( | ||
| value.begin(), value.end(), value.begin(), | ||
| [](unsigned char c) { return std::toupper(c); }); |
There was a problem hiding this comment.
Suggested change
| std::transform( | |
| value.begin(), value.end(), value.begin(), | |
| [](unsigned char c) { return std::toupper(c); }); | |
| std::transform(value.begin(), value.end(), value.begin(), std::toupper); |
| { | ||
| if (Kind() != TRITONSERVER_INSTANCEGROUPKIND_CPU) { | ||
| throw triton::backend::BackendModelInstanceException(TRITONSERVER_ErrorNew( | ||
| TRITONSERVER_ERROR_INVALID_ARG, | ||
| (std::string("unable to load model '") + model_state_->Name() + | ||
| "', Triton openVINO backend supports only CPU device") | ||
| "', Triton OpenVINO backend supports only Kind CPU and AUTO") |
There was a problem hiding this comment.
Wouldn't we exit here for target device = GPU?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is updated version of #74 which doesn't require any changed on the base triton image.
It gives option to specify TARGET_DEVICE to be passed to the OpenVINO Runtime during model compilation