-
Notifications
You must be signed in to change notification settings - Fork 78
Update 'main' to track the 25.03 release #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -12,11 +12,11 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
ARG BASE_IMAGE=nvcr.io/nvidia/tritonserver:24.12-py3 | |||
ARG TRITONSDK_BASE_IMAGE=nvcr.io/nvidia/tritonserver:24.12-py3-sdk | |||
ARG BASE_IMAGE=nvcr.io/nvidia/tritonserver:25.01-py3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 25.01?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand, it is 25.01?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thougth we were already at 25.02
but @mc-nv has the correct comment. This actually doesn't need to be done at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As development is stopped for MA. We may not want to update version and keep last one released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a tools team decision. @debermudez, is this PR necessary or should I close this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to make sure nothing is broken each release at this point.
So long as a pipeline has been triggered to ensure nothing is broken, we can close this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is going to be the strategy if there is a bug which needs to be patched? Will that go into a new release or will it go into a re-release of the final version of MA? This is the last issue I want resolved before I close this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nv-braf how are we handling that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've stopped active development of the tool (for now), but it is highly likely that we will have to add a new feature or implement a fix in the future, especially if the interface to PA changes.
What is prevent us from releasing a new version of MA in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing from the operations side as far as I can tell. We will manage your project how you tell us.
No description provided.