Skip to content

feat(webapp): add SENTRY_ENVIRONMENT to override the Sentry environment #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericallam wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

feat(webapp): add SENTRY_ENVIRONMENT to override the Sentry environment #4078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44543d6
feat(webapp): add SENTRY_ENVIRONMENT to override the Sentry environment
ericallam Jun 29, 2026
fae3743
Delete .server-changes/sentry-environment-override.md
ericallam Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/webapp/app/env.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ const EnvironmentSchema = z
APP_ENV: z.string().default(process.env.NODE_ENV),
SERVICE_NAME: z.string().default("trigger.dev webapp"),
SENTRY_DSN: z.string().optional(),
SENTRY_ENVIRONMENT: z.string().optional(),

@devin-ai-integration devin-ai-integration Bot Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Server-only change ships without a release-notes entry

The change touches only webapp server code (SENTRY_ENVIRONMENT added at apps/webapp/app/env.server.ts:154) but the accompanying release-notes entry was removed in the final commit, so this change will be missing from the release notes.
Impact: Users reading the release notes won't see that the new Sentry environment override exists.

Repository rule: server-only PRs require a .server-changes file

CONTRIBUTING.md ("Adding server changes") requires that a PR changing only apps/webapp/ with no package changes adds a .server-changes/ markdown file with area and type frontmatter. The branch added .server-changes/sentry-environment-override.md in commit 44543d60e and then deleted it in the head commit fae374368, leaving the PR with no release-notes entry while modifying apps/webapp/app/env.server.ts and apps/webapp/sentry.server.ts.

Prompt for agents 
This PR modifies only server components (apps/webapp), so per CONTRIBUTING.md it needs a .server-changes/ markdown file with `area: webapp` and `type: feature` frontmatter plus a one-line description. Such a file (.server-changes/sentry-environment-override.md) was added earlier in the branch but deleted in the head commit; it should be restored.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

POSTHOG_PROJECT_KEY: z.string().default("phc_LFH7kJiGhdIlnO22hTAKgHpaKhpM8gkzWAFvHmf5vfS"),
TRIGGER_TELEMETRY_DISABLED: z.string().optional(),
AUTH_GITHUB_CLIENT_ID: z.string().optional(),
Expand Down
3 changes: 2 additions & 1 deletion apps/webapp/sentry.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ if (process.env.SENTRY_DSN) {
shutdownTimeout: 10,

serverName: process.env.SERVICE_NAME,
environment: process.env.APP_ENV,
// Falls back to APP_ENV; set SENTRY_ENVIRONMENT to override (e.g. preview deployments) without touching APP_ENV.
environment: process.env.SENTRY_ENVIRONMENT ?? process.env.APP_ENV,
Comment thread
ericallam marked this conversation as resolved.

// ServiceValidationError is thrown deliberately for user-facing
// validation failures (quota, parent run state, invalid input). Anchored
Expand Down